patak comments

Results 443 comments of


                                            patak

fix: external URLs don't have to start with http(s)

/ecosystem-ci run

fix: external URLs don't have to start with http(s)

/ecosystem-ci run vite-plugin-vue

fix: external URLs don't have to start with http(s)

Good call with `file://`, that shouldn't be considered external. Could you expand on the `virtual:` issue? The regex will only match ids with `xxx://`, no?

fix: external URLs don't have to start with http(s)

/ecosystem-ci run

fix: external URLs don't have to start with http(s)

/ecosystem-ci run

fix: external URLs don't have to start with http(s)

The vite-plugin-pwa looks like a fluke due to a failed sharp install. @bluwy, the Astro fail seems legit. It seems there is a test for `file://` in Astro's CI. So...

fix: external URLs don't have to start with http(s)

> here It seems that Astro decided to make `file://path` URLs equivalent to `path` though. If Vite resolves them as external by default and frameworks start to add plugins to...

fix: external URLs don't have to start with http(s)

If we want to do this, for now maybe we shouldn't change how `file://` works (by making them external). We can modify this PR to keep returning false for `file://`...

Show a QR code with the address in the terminal when using `--host`.

I really like this feature, but given that it can be achieved in user land it may be a good idea to keep things as is. Frameworks and users that...

fix: use websocket to test server liveness before client reload

Great work! I think it would be good to have this in Vite 6. I added it to the milestone.