charts-passbolt icon indicating copy to clipboard operation
charts-passbolt copied to clipboard

feat: Add Extra Containers Support

Open crhuber opened this issue 1 year ago • 3 comments

Adds support for extra containers to be added to the deployment. This is useful where teams have a need to add a sidecar container alongside the main application.

For example to use GCP CloudSQL you need to use cloudsqlproxy. Usage would be like so

  extraContainers:
    - name: cloud-sql-proxy
      image: gcr.io/cloud-sql-connectors/cloud-sql-proxy:2.1.2-alpine
      imagePullPolicy: IfNotPresent
      command:
        - "./cloud-sql-proxy"
        - "foo:europe-west1:bar"
        - "--port"
        - "5432"
        - "--structured-logs"
      ports:
        - containerPort: 5432
          protocol: TCP
        runAsNonRoot: true
      resources:
        limits:
          memory: 48Mi
        requests:
          cpu: 100m
          memory: 32Mi

crhuber avatar Sep 19 '24 11:09 crhuber

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 19 '24 11:09 CLAassistant

Hey @dlen any chance of a review here please? thanks

crhuber avatar Sep 30 '24 09:09 crhuber

hi @crhuber!

Thanks for your submission it is really appreciated! I'll merge this week!

dlen avatar Sep 30 '24 20:09 dlen

Hey @dlen, would you maybe have some updates regarding merging this change?

andmich351 avatar Oct 15 '24 13:10 andmich351

@dlen any news? I am looking forward to using this feature too 🙇

ngoduykhanh avatar Oct 28 '24 10:10 ngoduykhanh

Sorry guys I had some other priorities these last few weeks. @Tecnobutrul is taking care of this and other PR to make a release ASAP.

dlen avatar Oct 29 '24 14:10 dlen