OpenVAF icon indicating copy to clipboard operation
OpenVAF copied to clipboard

Fix for crash when compiling module with no parameters.

Open gjcoram opened this issue 1 year ago • 5 comments

See https://github.com/pascalkuthe/OpenVAF/issues/103

gjcoram avatar May 31 '24 18:05 gjcoram

This is the correct commit. Apparently, having a dummy parameter interns the empty string (possibly the unit or description of the parameter), so that the later lookup of the empty string finds a match.

gjcoram avatar Jun 19 '24 20:06 gjcoram

@gjcoram It seems that this patch follows in a crash compiling psphv version 1.0.6 (see https://github.com/dwarning/VA-Models/tree/main/code/psphv/vacode). Log file attached: openvaf-crash-1721544959.log

dwarning avatar Jul 21 '24 07:07 dwarning

@gjcoram Update README.md to point to this repository instead of pascalkuthe

I guess you went and officially forked this? are you mantaining it?

Kreijstal avatar Aug 18 '24 10:08 Kreijstal

I guess you went and officially forked this? are you mantaining it?

I hope to continue to improve it.

gjcoram avatar Sep 30 '24 19:09 gjcoram

I get something weird

thread 'main' panicked at openvaf/openvaf/tests/integration.rs:210:9:
assertion failed: `(left approx_eq right)`
  left: `624.0`,
 right: `78.0`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test noise                        ... test panicked: assertion failed: `(left approx_eq right)`
  left: `624.0`,
 right: `78.0`
FAILED

 failures:

    noise
test result: FAILED. 1 passed; 1 failed; 26 ignored; 0 filtered out; finished in 0.10s

trying to merge this branch

Kreijstal avatar Oct 27 '24 22:10 Kreijstal