partiql-lang-kotlin icon indicating copy to clipboard operation
partiql-lang-kotlin copied to clipboard

Ports evaluation changes to v1 plans

Open rchowell opened this issue 1 year ago • 1 comments

Relevant Issues

#1548

Description

This PR applies the modifications to the v1.plan package which we needed to switch the intermediate representation used for execution.

It adds,

  • dynamic calls
  • exclude
  • paths
  • nullif

There are cleanup TODOs for several things we needed to pass existing tests with minimal changes, these include

  • removal of nullif?
  • fix subqueries in planner
  • join schemas?

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rchowell avatar Aug 30 '24 19:08 rchowell

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (v1@53098ee). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v1    #1573   +/-   ##
=====================================
  Coverage      ?   77.23%           
  Complexity    ?     2514           
=====================================
  Files         ?      253           
  Lines         ?    18563           
  Branches      ?     3523           
=====================================
  Hits          ?    14337           
  Misses        ?     3192           
  Partials      ?     1034           
Flag Coverage Δ
EXAMPLES 80.07% <ø> (?)
LANG 77.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 30 '24 19:08 codecov-commenter

CROSS-ENGINE Conformance Report :x:

BASE (EVAL-829611E) TARGET (LEGACY-829611E) +/-
% Passing 94.22% 89.65% -4.56% :o:
Passing 5555 5286 -269 :o:
Failing 74 610 536 :o:
Ignored 267 0 -267 :white_check_mark:
Total Tests 5896 5896 0 :white_check_mark:

Testing Details

  • Base Commit: 829611ee625e6e4addb679d52ad269b40990207c
  • Base Engine: EVAL
  • Target Commit: 829611ee625e6e4addb679d52ad269b40990207c
  • Target Engine: LEGACY

Result Details

  • :x: REGRESSION DETECTED. See Now Failing Tests. :x:
  • Passing in both: 5019
  • Failing in both: 74
  • PASSING in BASE but now FAILING in TARGET: 536
  • FAILING in BASE but now PASSING in TARGET: 0

Now Failing Tests :x:

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-EVAL Conformance Report :white_check_mark:

BASE (EVAL-A54F6AD) TARGET (EVAL-829611E) +/-
% Passing 94.22% 94.22% 0.00% :white_check_mark:
Passing 5555 5555 0 :white_check_mark:
Failing 74 74 0 :white_check_mark:
Ignored 267 267 0 :white_check_mark:
Total Tests 5896 5896 0 :white_check_mark:

Testing Details

  • Base Commit: a54f6ad5a2304a008184d6127e38d27141f31914
  • Base Engine: EVAL
  • Target Commit: 829611ee625e6e4addb679d52ad269b40990207c
  • Target Engine: EVAL

Result Details

  • Passing in both: 5555
  • Failing in both: 74
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0

CROSS-COMMIT-LEGACY Conformance Report :white_check_mark:

BASE (LEGACY-A54F6AD) TARGET (LEGACY-829611E) +/-
% Passing 89.65% 89.65% 0.00% :white_check_mark:
Passing 5286 5286 0 :white_check_mark:
Failing 610 610 0 :white_check_mark:
Ignored 0 0 0 :white_check_mark:
Total Tests 5896 5896 0 :white_check_mark:

Testing Details

  • Base Commit: a54f6ad5a2304a008184d6127e38d27141f31914
  • Base Engine: LEGACY
  • Target Commit: 829611ee625e6e4addb679d52ad269b40990207c
  • Target Engine: LEGACY

Result Details

  • Passing in both: 5286
  • Failing in both: 610
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0

github-actions[bot] avatar Sep 05 '24 20:09 github-actions[bot]