parse-server
parse-server copied to clipboard
refactor: Bump prettier from 2.0.5 to 3.5.3
Pull Request
- Report security issues confidentially.
- Any contribution is under this license.
- Link this pull request to an issue.
Issue
Closes: #9625
Approach
Tasks
- [ ] Add tests
- [ ] Add changes to documentation (guides, repository pages, code comments)
- [ ] Add security check
- [ ] Add new Parse Error codes to Parse JS SDK
🚀 Thanks for opening this pull request!
Codecov Report
Attention: Patch coverage is 92.15686% with 8 lines in your changes missing coverage. Please review.
Project coverage is 92.97%. Comparing base (
f3f28f8) to head (82fc7f5).
Additional details and impacted files
@@ Coverage Diff @@
## alpha #9671 +/- ##
==========================================
- Coverage 93.00% 92.97% -0.03%
==========================================
Files 187 187
Lines 15082 15110 +28
Branches 174 174
==========================================
+ Hits 14027 14049 +22
- Misses 1043 1049 +6
Partials 12 12
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
What did this PR require? Only upgrading the dependency? I thought it was more because the definitions check failed.
I assume all the other changes are because you ran lint:fix?
I upgraded the dependency and ran prettier + lint
I think we need to be careful running prettier across the whole code base. It could disrupt existing PRs, because the rebase may be difficult. We also have no automation in place to ensure prettier before merge, so this is a continuing cycle. A pre-commit hook is not a good solution. I'd suggest to run prettier --check in the CI, just like we do for lint.
Interestingly, I ran npm run prettier && npm run lint-fix and get many changes. I think it's unlikely that they all come from the last few alpha merges:
:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)
[!WARNING]
Rate limit exceeded
@dblythy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 9 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the
@coderabbitai reviewcommand as a PR comment. Alternatively, push new commits to this PR.We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.
📥 Commits
Reviewing files that changed from the base of the PR and between f3f28f8f5e4a1c6fde9d46bdd1c9daec27bda067 and 82fc7f54cdb0a2fc4356d4b4a5939a4621754e54.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json📒 Files selected for processing (91)
package.json(1 hunks)spec/AudienceRouter.spec.js(1 hunks)spec/Auth.spec.js(1 hunks)spec/AuthenticationAdapters.spec.js(8 hunks)spec/AuthenticationAdaptersV2.spec.js(11 hunks)spec/CLI.spec.js(2 hunks)spec/CloudCode.Validator.spec.js(3 hunks)spec/CloudCode.spec.js(12 hunks)spec/CloudCodeLogger.spec.js(4 hunks)spec/DatabaseController.spec.js(4 hunks)spec/DefinedSchemas.spec.js(14 hunks)spec/EmailVerificationToken.spec.js(8 hunks)spec/FilesController.spec.js(5 hunks)spec/GridFSBucketStorageAdapter.spec.js(1 hunks)spec/Idempotency.spec.js(2 hunks)spec/JobSchedule.spec.js(1 hunks)spec/LoggerController.spec.js(1 hunks)spec/LogsRouter.spec.js(3 hunks)spec/Middlewares.spec.js(2 hunks)spec/MongoSchemaCollectionAdapter.spec.js(1 hunks)spec/MongoStorageAdapter.spec.js(2 hunks)spec/PagesRouter.spec.js(7 hunks)spec/Parse.Push.spec.js(1 hunks)spec/ParseACL.spec.js(1 hunks)spec/ParseAPI.spec.js(4 hunks)spec/ParseCloudCodePublisher.spec.js(1 hunks)spec/ParseConfigKey.spec.js(1 hunks)spec/ParseFile.spec.js(2 hunks)spec/ParseGeoPoint.spec.js(4 hunks)spec/ParseGlobalConfig.spec.js(2 hunks)spec/ParseGraphQLSchema.spec.js(1 hunks)spec/ParseHooks.spec.js(3 hunks)spec/ParseInstallation.spec.js(3 hunks)spec/ParseLiveQuery.spec.js(5 hunks)spec/ParseObject.spec.js(4 hunks)spec/ParsePubSub.spec.js(6 hunks)spec/ParseQuery.Aggregate.spec.js(8 hunks)spec/ParseQuery.FullTextSearch.spec.js(1 hunks)spec/ParseQuery.spec.js(14 hunks)spec/ParseRole.spec.js(2 hunks)spec/ParseServerRESTController.spec.js(3 hunks)spec/ParseSession.spec.js(1 hunks)spec/ParseUser.spec.js(6 hunks)spec/PasswordPolicy.spec.js(10 hunks)spec/PointerPermissions.spec.js(10 hunks)spec/PostgresInitOptions.spec.js(1 hunks)spec/PostgresStorageAdapter.spec.js(2 hunks)spec/PushController.spec.js(4 hunks)spec/PushWorker.spec.js(1 hunks)spec/RateLimit.spec.js(5 hunks)spec/RestQuery.spec.js(1 hunks)spec/SchemaPerformance.spec.js(1 hunks)spec/SecurityCheck.spec.js(1 hunks)spec/Uniqueness.spec.js(1 hunks)spec/UserController.spec.js(1 hunks)spec/Utils.spec.js(2 hunks)spec/ValidationAndPasswordsReset.spec.js(9 hunks)spec/WinstonLoggerAdapter.spec.js(2 hunks)spec/batch.spec.js(1 hunks)spec/eslint.config.js(1 hunks)spec/helper.js(5 hunks)spec/index.spec.js(1 hunks)spec/rest.spec.js(1 hunks)spec/schemas.spec.js(2 hunks)spec/support/CurrentSpecReporter.js(5 hunks)spec/support/MockLdapServer.js(1 hunks)spec/vulnerabilities.spec.js(3 hunks)src/Auth.js(1 hunks)src/Controllers/DatabaseController.js(6 hunks)src/Controllers/FilesController.js(2 hunks)src/Controllers/SchemaController.js(2 hunks)src/Controllers/UserController.js(3 hunks)src/GraphQL/parseGraphQLUtils.js(1 hunks)src/Options/Definitions.js(32 hunks)src/ParseServerRESTController.js(1 hunks)src/RestQuery.js(1 hunks)src/RestWrite.js(8 hunks)src/Routers/GlobalConfigRouter.js(1 hunks)src/Routers/GraphQLRouter.js(1 hunks)src/Routers/IAPValidationRouter.js(1 hunks)src/Routers/PagesRouter.js(1 hunks)src/Routers/PublicAPIRouter.js(1 hunks)src/Routers/UsersRouter.js(5 hunks)src/SchemaMigrations/DefinedSchemas.js(6 hunks)src/StatusHandler.js(1 hunks)src/TestUtils.js(2 hunks)src/Utils.js(2 hunks)src/cli/parse-server.js(0 hunks)src/cloud-code/Parse.Cloud.js(4 hunks)src/middlewares.js(6 hunks)src/vendor/mongodbUrl.js(23 hunks)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai generate unit teststo generate unit tests for this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@mtrezza how do you think we should handle this?