parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

Incorrect definition for NumberOrBoolean check in resources/buildConfigDefinition.js

Open magnacartatron opened this issue 8 months ago • 2 comments
trafficstars

New Issue Checklist

Issue Description

Error in code base. ParseServerOption cluster param uses NumberOrBoolean for check

/* Run with cluster, optionally set the number of processes default to os.cpus().length */
  cluster: ?NumberOrBoolean;

In resources/buildConfigDefinition.js NumberOrBoolean assigns the function numberOrBooleanParser

if (type == 'NumberOrBoolean') {
      return wrap(t.identifier('numberOrBooleanParser'));
    }

This function does not exist in src/Options/parsers.js The correct function is numberOrBoolParser

function numberOrBoolParser(key) {
  return function (opt) {
    if (typeof opt === 'boolean') {
      return opt;
    }
    if (opt === 'true') {
      return true;
    }
    if (opt === 'false') {
      return false;
    }
    return numberParser(key)(opt);
  };
}

Environment

ubuntu 24.04

Server

  • Parse Server version: 8.0.1-alpha.1
  • Operating system: ubuntu 24.04
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local

magnacartatron avatar Mar 13 '25 06:03 magnacartatron

🚀 Thanks for opening this issue!

ℹ️ You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

Would you want to open a PR for this fix?

mtrezza avatar Mar 17 '25 23:03 mtrezza