parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

feat: Upgrade to parse 5.1.0

Open mtrezza opened this issue 1 year ago • 2 comments
trafficstars

mtrezza avatar May 16 '24 16:05 mtrezza

Thanks for opening this pull request!

@parse-community/server @parse-community/js-sdk could someone take a look at why this CI fails when upgrading the Parse JS SDK? It seems that there are a 6 or so tests that consistently fail.

mtrezza avatar May 16 '24 20:05 mtrezza

@mtrezza @parse-community/server @parse-community/js-sdk Looks like https://github.com/parse-community/Parse-SDK-JS/pull/1453 is the cause. Although attributes does take care of pending operations, those pending operation returned from toJSON are heavily used in cloud code.

dplewis avatar Jun 06 '24 17:06 dplewis

test-upgrade to parse 5.2.0-beta.1, to see whether CI passes, i.e. whether https://github.com/parse-community/Parse-SDK-JS/pull/2162 fixed the issue. Before merge: release parse 5.2.0 stable and upgrade to that in this PR.

mtrezza avatar Jun 24 '24 21:06 mtrezza

CI now fails using parse 5.2.0-beta.1 with:

  1. PushWorker pushStatus tracks push status per UTC offsets
  • Expected undefined to be 1.
  • Expected undefined to be 1.
  • Expected undefined to be 3.
  • Expected undefined to be 2.

Not sure whether this is related to https://github.com/parse-community/Parse-SDK-JS/pull/2162, or a different issue. @dplewis if you could take a look...

mtrezza avatar Jun 24 '24 22:06 mtrezza

It is related because sentPerUTCOffset and failed PerUTCOffset use dot notation even though they are saved as strings so a check is needed

dplewis avatar Jun 24 '24 22:06 dplewis

@dplewis if you find the time to open a fix for this, that would be great

mtrezza avatar Jun 25 '24 23:06 mtrezza

Test upgrade to parse 5.2.0-alpha.4, to see if https://github.com/parse-community/Parse-SDK-JS/pull/2194 fixed the issue.

mtrezza avatar Jun 28 '24 22:06 mtrezza

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.16%. Comparing base (885aa12) to head (d6d248d).

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9128      +/-   ##
==========================================
+ Coverage   93.80%   94.16%   +0.35%     
==========================================
  Files         186      186              
  Lines       14726    14726              
==========================================
+ Hits        13814    13867      +53     
+ Misses        912      859      -53     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 28 '24 22:06 codecov[bot]

@mtrezza looks good to me 👍

dplewis avatar Jun 28 '24 23:06 dplewis

Yes, finally, thanks for the fixes @dplewis

mtrezza avatar Jun 29 '24 08:06 mtrezza

Changed to draft as to not merge it accidentally before changing the parse dependency to a stable release

mtrezza avatar Jun 29 '24 08:06 mtrezza

🎉 This change has been released in version 7.1.0-alpha.11

parseplatformorg avatar Jun 29 '24 18:06 parseplatformorg

🎉 This change has been released in version 7.1.0-beta.1

parseplatformorg avatar Jun 30 '24 02:06 parseplatformorg

🎉 This change has been released in version 7.1.0

parseplatformorg avatar Jun 30 '24 02:06 parseplatformorg

🎉 This change has been released in version 7.3.0-alpha.1

parseplatformorg avatar Jul 09 '24 11:07 parseplatformorg

🎉 This change has been released in version 7.3.0-beta.1

parseplatformorg avatar Oct 03 '24 19:10 parseplatformorg

🎉 This change has been released in version 7.3.0

parseplatformorg avatar Oct 03 '24 20:10 parseplatformorg