parse-server
parse-server copied to clipboard
feat: Upgrade to parse 5.1.0
Thanks for opening this pull request!
@parse-community/server @parse-community/js-sdk could someone take a look at why this CI fails when upgrading the Parse JS SDK? It seems that there are a 6 or so tests that consistently fail.
@mtrezza @parse-community/server @parse-community/js-sdk Looks like https://github.com/parse-community/Parse-SDK-JS/pull/1453 is the cause. Although attributes does take care of pending operations, those pending operation returned from toJSON are heavily used in cloud code.
test-upgrade to parse 5.2.0-beta.1, to see whether CI passes, i.e. whether https://github.com/parse-community/Parse-SDK-JS/pull/2162 fixed the issue. Before merge: release parse 5.2.0 stable and upgrade to that in this PR.
CI now fails using parse 5.2.0-beta.1 with:
- PushWorker pushStatus tracks push status per UTC offsets
- Expected undefined to be 1.
- Expected undefined to be 1.
- Expected undefined to be 3.
- Expected undefined to be 2.
Not sure whether this is related to https://github.com/parse-community/Parse-SDK-JS/pull/2162, or a different issue. @dplewis if you could take a look...
It is related because sentPerUTCOffset and failed PerUTCOffset use dot notation even though they are saved as strings so a check is needed
@dplewis if you find the time to open a fix for this, that would be great
Test upgrade to parse 5.2.0-alpha.4, to see if https://github.com/parse-community/Parse-SDK-JS/pull/2194 fixed the issue.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.16%. Comparing base (
885aa12) to head (d6d248d).
Additional details and impacted files
@@ Coverage Diff @@
## alpha #9128 +/- ##
==========================================
+ Coverage 93.80% 94.16% +0.35%
==========================================
Files 186 186
Lines 14726 14726
==========================================
+ Hits 13814 13867 +53
+ Misses 912 859 -53
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mtrezza looks good to me 👍
Yes, finally, thanks for the fixes @dplewis
Changed to draft as to not merge it accidentally before changing the parse dependency to a stable release
🎉 This change has been released in version 7.1.0-alpha.11
🎉 This change has been released in version 7.1.0-beta.1
🎉 This change has been released in version 7.1.0
🎉 This change has been released in version 7.3.0-alpha.1
🎉 This change has been released in version 7.3.0-beta.1
🎉 This change has been released in version 7.3.0