parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

Published 20 hours ago • verified publisher icon parse-community

fix: invalid json logs incorrectly

Open dblythy opened this issue 3 years ago • 2 comments
trafficstars

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Invalid JSON is currently logged as a string, which converts to [object Object]

Related issue: n/a

Approach

Stringifies error for easier debugging

TODOs before merging

  • [x] Add tests
  • [x] A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

dblythy avatar Sep 13 '22 07:09 dblythy

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

parse-github-assistant[bot] avatar Sep 13 '22 07:09 parse-github-assistant[bot]

Codecov Report

Base: 94.20% // Head: 94.20% // No change to project coverage :thumbsup:

Coverage data is based on head (4d1c620) compared to base (3c75c2b). Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #8164   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files         182      182           
  Lines       13720    13720           
=======================================
  Hits        12925    12925           
  Misses        795      795
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoTransform.js 88.41% <ø> (ø)
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) :arrow_down:
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.94% <0.00%> (-0.22%) :arrow_down:
src/Controllers/DatabaseController.js 93.89% <0.00%> (+0.14%) :arrow_up:
src/ParseServerRESTController.js 98.48% <0.00%> (+1.51%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 13 '22 07:09 codecov[bot]

@dblythy Any particular reason why this was closed?

mtrezza avatar Dec 17 '22 02:12 mtrezza