parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

fix: lru deprecation warnings

Open Moumouls opened this issue 3 years ago • 4 comments
trafficstars

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

LRU warnings introduced after lru update

Related issue: NONE

Approach

Update API

TODOs before merging

  • [x] A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

Moumouls avatar Jun 14 '22 15:06 Moumouls

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

Codecov Report

Merging #8046 (37a9cdf) into alpha (72fac8a) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            alpha    #8046   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         182      182           
  Lines       13659    13659           
=======================================
  Hits        12858    12858           
  Misses        801      801           
Impacted Files Coverage Δ
src/Adapters/Cache/LRUCache.js 100.00% <100.00%> (ø)
src/LiveQuery/ParseLiveQueryServer.js 95.65% <100.00%> (ø)
src/RestWrite.js 94.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72fac8a...37a9cdf. Read the comment docs.

codecov[bot] avatar Jun 14 '22 15:06 codecov[bot]

@mtrezza if you have a suggestion, this PR just fix LRU depreciation warnings.

It was introduced after the LRU cache package update.

Moumouls avatar Jun 14 '22 21:06 Moumouls

The changes only show some method renaming, this PR needs more info. As you know, we require an issue for a PR, to avoid these fundamental Q/As about PRs.

mtrezza avatar Jun 15 '22 10:06 mtrezza

closing since it's now outdated

Moumouls avatar Nov 14 '22 23:11 Moumouls