parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

feat: add definitions CI check

Open dblythy opened this issue 3 years ago • 5 comments
trafficstars

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Often, the definitions files are manually edited.

Related issue: #7918

Approach

Generates definitions and compares to committed definitions

TODOs before merging

  • [x] A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

dblythy avatar Apr 28 '22 05:04 dblythy

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Codecov Report

Base: 94.25% // Head: 94.25% // No change to project coverage :thumbsup:

Coverage data is based on head (d4e3ae6) compared to base (e22b73d). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #7955   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files         180      180           
  Lines       13987    13987           
=======================================
  Hits        13183    13183           
  Misses        804      804           
Impacted Files Coverage Δ
src/RestWrite.js 94.76% <0.00%> (-0.15%) :arrow_down:
src/Adapters/Files/GridFSBucketAdapter.js 94.16% <0.00%> (+0.72%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 28 '22 05:04 codecov[bot]

Not quite sure why this runs fine locally but github actions responds with [Error: ENOENT: no such file or directory, open './src/options/Definitions.js'] {

dblythy avatar Apr 28 '22 13:04 dblythy

Likely because in the GH container environment the path root is different from your local env.

mtrezza avatar Apr 28 '22 15:04 mtrezza

Ok, thanks for the pointers CI expert! If you could have a quick look at the approach and let me know your general thoughts some time that would be great.

dblythy avatar Apr 28 '22 15:04 dblythy

I will reformat the title to use the proper commit message syntax.

🎉 This change has been released in version 6.0.0-alpha.15

parseplatformorg avatar Dec 20 '22 15:12 parseplatformorg

🎉 This change has been released in version 6.0.0-beta.1

parseplatformorg avatar Jan 31 '23 03:01 parseplatformorg

🎉 This change has been released in version 6.0.0

parseplatformorg avatar Jan 31 '23 03:01 parseplatformorg