parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

fix: set default Content Type header to "binary/octet-stream"

Open igor-lemon opened this issue 4 years ago • 6 comments
trafficstars

New Pull Request Checklist

I can't download a file with ext *.data. The parse server return Content-Type: null I would to have a default type Content-Type: binary/octet-stream

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Related issue: #7572

  • [ ] Add test cases
  • [ ] Add entry to changelog
  • [ ] Add changes to documentation (guides, repository pages, in-code descriptions)
  • [ ] Add security check
  • [ ] Add new Parse Error codes to Parse JS SDK
  • [ ] ...

igor-lemon avatar Oct 02 '21 13:10 igor-lemon

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

I think it should be a more pretty solution than add Content-Disposition header as I did in the prev PR #7571

igor-lemon avatar Oct 02 '21 13:10 igor-lemon

I will reformat the title to use the proper commit message syntax.

Codecov Report

Merging #7603 (25d1dc5) into master (fdb7dfb) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7603      +/-   ##
==========================================
+ Coverage   93.94%   93.97%   +0.03%     
==========================================
  Files         181      181              
  Lines       13279    13354      +75     
==========================================
+ Hits        12475    12550      +75     
  Misses        804      804              
Impacted Files Coverage Δ
src/Routers/FilesRouter.js 88.54% <100.00%> (ø)
src/batch.js 91.37% <0.00%> (-1.73%) :arrow_down:
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) :arrow_down:
src/RestWrite.js 94.04% <0.00%> (-0.07%) :arrow_down:
src/Options/Definitions.js 100.00% <0.00%> (ø)
src/GraphQL/loaders/functionsMutations.js 100.00% <0.00%> (ø)
src/GraphQL/loaders/parseClassMutations.js 100.00% <0.00%> (ø)
src/cloud-code/Parse.Cloud.js 99.20% <0.00%> (+<0.01%) :arrow_up:
src/GraphQL/loaders/parseClassQueries.js 98.03% <0.00%> (+0.03%) :arrow_up:
src/Config.js 93.39% <0.00%> (+0.08%) :arrow_up:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdb7dfb...25d1dc5. Read the comment docs.

codecov[bot] avatar Oct 24 '21 16:10 codecov[bot]

Did this ever get pushed to a live version? Seems to make sense.

santiagoprieto avatar Sep 08 '23 22:09 santiagoprieto

@santiagoprieto See https://github.com/parse-community/parse-server/issues/7572

mtrezza avatar Sep 08 '23 23:09 mtrezza