fix: custom field name collides with internal field name

[julianvogels]

trafficstars

New Pull Request Checklist

• [x] I am not disclosing a vulnerability.
• [x] I am creating this PR in reference to issue #7130.

Issue Description

This PR doesn't fix the issue, but adds a failing test which demonstrates the problem.

The test

1. saves a test object
2. sets an invalid field length to 1
3. saves the test object again
4. beforeSave hook unsets the invalid field length

Expected result: The beforeSave hook succeeds to unset the invalid field.

Actual result: An error 105 – Invalid field name for update: length is thrown before the beforeSave hook is executed, and no unset operation is done.

Related issue: #7130

Approach

The test was added in the CloudCode.spec.js file.

[dplewis]

Thanks for the test. I can do a fix for this since I introduced it. I also have a few more fields that will be reserved.

[mtrezza]

⚠️ Important change for merging PRs from Parse Server 5.0 onwards!

We are planning to release the first beta version of Parse Server 5.0 in October 2021.

If a PR contains a breaking change and is not merged before the beta release of Parse Server 5.0, it cannot be merged until the end of 2022. Instead it has to follow the Deprecation Policy and phase-in breaking changes to be merged during the course of 2022.

One of the most voiced community feedbacks was the demand for predictability in breaking changes to make it easy to upgrade Parse Server. We have made a first step towards this by introducing the Deprecation Policy in February 2021 that assists to phase-in breaking changes, giving developers time to adapt. We will follow-up with the introduction of Release Automation and a branch model that will allow breaking changes only with a new major release, scheduled for the beginning of each calendar year.

We understand that some PRs are a long time in the making and we very much appreciate your contribution. We want to make it easy for PRs that contain a breaking change and were created before the introduction of the Deprecation Policy. These PRs can be merged with a breaking change without being phased-in before the beta release of Parse Server 5.0. We are making this exception because we appreciate that this is a time of transition that requires additional effort from contributors to adapt. We encourage everyone to prepare their PRs until the end of September and account for review time and possible adaptions.

If a PR contains a breaking change and should be merged before the beta release, please mention @parse-community/server-maintenance and we will coordinate with you to merge the PR.

Thanks for your contribution and support during this transition to Parse Server release automation!

[pausenabre]

@dplewis is there any update in relation to this issue? or any planned development on this?

[mtrezza]

@pausenabre I assume this is a larger effort, see the discussion in the related issue. The issue is still open.