parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

Published 20 hours ago • verified publisher icon parse-community

Fix saving object with invalid iso date

Open mtrezza opened this issue 4 years ago • 8 comments
trafficstars

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Saving an object with a date field set to an invalid ISO date object does not fail. The object is saved with field date value 1970-01-01T00:00:00.000Z.

Related issue: closes https://github.com/parse-community/parse-server/issues/7054

Approach

Add date validation and reject invalid ISO date. This should most likely be part of the schema validation.

TODOs before merging

  • [x] Add test cases
  • [ ] Add bug fix
  • [ ] Add entry to changelog

mtrezza avatar Dec 19 '20 22:12 mtrezza

Contains only the failing test case so far to verify the issue.

mtrezza avatar Dec 20 '20 02:12 mtrezza

Can you rebase from master?

dplewis avatar Feb 19 '21 21:02 dplewis

@dplewis done

mtrezza avatar Feb 20 '21 19:02 mtrezza

Can you look at your test?

dplewis avatar Feb 20 '21 21:02 dplewis

The test is failing correctly. This PR does not yet contain a fix, it was just to verify that this is actually a bug.

mtrezza avatar Feb 21 '21 01:02 mtrezza

@dplewis @mtrezza Any progress on this?

sunshineo avatar Jun 30 '21 20:06 sunshineo

@sunshineo This PR is still only containing a failing test to demo the issue. Feel free to investigate, I think I can give you PR access if you want to work on it.

mtrezza avatar Jul 03 '21 18:07 mtrezza

⚠️ Important change for merging PRs from Parse Server 5.0 onwards!

We are planning to release the first beta version of Parse Server 5.0 in October 2021.

If a PR contains a breaking change and is not merged before the beta release of Parse Server 5.0, it cannot be merged until the end of 2022. Instead it has to follow the Deprecation Policy and phase-in breaking changes to be merged during the course of 2022.

One of the most voiced community feedbacks was the demand for predictability in breaking changes to make it easy to upgrade Parse Server. We have made a first step towards this by introducing the Deprecation Policy in February 2021 that assists to phase-in breaking changes, giving developers time to adapt. We will follow-up with the introduction of Release Automation and a branch model that will allow breaking changes only with a new major release, scheduled for the beginning of each calendar year.

We understand that some PRs are a long time in the making and we very much appreciate your contribution. We want to make it easy for PRs that contain a breaking change and were created before the introduction of the Deprecation Policy. These PRs can be merged with a breaking change without being phased-in before the beta release of Parse Server 5.0. We are making this exception because we appreciate that this is a time of transition that requires additional effort from contributors to adapt. We encourage everyone to prepare their PRs until the end of September and account for review time and possible adaptions.

If a PR contains a breaking change and should be merged before the beta release, please mention @parse-community/server-maintenance and we will coordinate with you to merge the PR.

Thanks for your contribution and support during this transition to Parse Server release automation!

mtrezza avatar Sep 03 '21 00:09 mtrezza