Wrong options type when set from environment variables

[danielsanfr]

Hello.

While I was implementing PR: https://github.com/parse-community/parse-server-s3-adapter/pull/117, I encountered a problem with the environment variables.

As you can see in the image below, the _baseUrlDirect variable has the correct type (boolean), as it was not set via the environment variable. However, the other two _directAccess and _presignedUrl variables that were set as environment variables, are not being converted to the correct type (it should be boolean).

This problem causes a check of the form if (_directAccess) { ... }, do not be verified as expected.

I would like to know if I can create a PR using the https://www.npmjs.com/package/boolean lib to do this conversion?

I don't know if you noticed, but the _presignedUrlExpires variable should be an integer, but it is also a string. However, this case can be solved with the standard parseInt() Javascript library.

[davimacedo]

Thanks for reporting. I believe we do not need a package for that. We just need to convert in this line: https://github.com/parse-community/parse-server-s3-adapter/blob/master/lib/optionsFromArguments.js#L91

Do you want to open a PR?

[danielsanfr]

OK, sorry if I'm being boring, but I will need this solution for 3 variables baseUrlRirect, directAccess and presignedUrl. I will end up having to create a function for this. But looking at the library code, it only has 1 function, has no dependency and already has unit tests. I don't see why not use it?

https://github.com/thenativeweb/boolean/blob/master/lib/boolean.ts

It has nothing to do with this issue, but I don't know if I should create another issue to remove this doubt. Why does this project depend on the parse SDK if it is not used for anything? I think we could remove that dependency.

[davimacedo]

Ok. No problem. You can use the library.

[danielsanfr]

Thanks! I will do a PR as soon as the PR (https://github.com/parse-community/parse-server-s3-adapter/pull/117) has been accepted.