node-apn
node-apn copied to clipboard
feat: allow certificate validation errors to be caught instead of terminating
This came up in the context of pushd. If there are a lot of push notification destinations set up, all with their own certificates, it's not ideal for one expired certificate to cause a terminating failure.
This tiny change wraps the validation in a try/catch so a validation error is still logged, but execution can continue.
Joe
Sorry for the long delay on this one. I like the idea. I believe we should continue terminating in the case there is no valid certificates though. What do you think?
Thanks for opening this pull request!
- ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.