Parse-SDK-iOS-OSX icon indicating copy to clipboard operation
Parse-SDK-iOS-OSX copied to clipboard

fix: macOS command line app crash

Open JohnCaccavale opened this issue 6 years ago • 14 comments

This PR Resolves issue #1391 where a macOS Command Line App will crash when the Parse Framework is installed in /Library/Frameworks/

JohnCaccavale avatar Mar 08 '19 21:03 JohnCaccavale

Could anyone take a look at this? - @mrmarcsmith @jjmaceda @kennic

TomWFox avatar Mar 17 '19 17:03 TomWFox

Thanks @JohnCaccavale for this PR! I know this may be difficult given the nature of this PR but can you think of any way to write a test to ensure current and future functionality?

mrmarcsmith avatar Mar 17 '19 22:03 mrmarcsmith

Sorry, I've been very busy lately. Will try to take a look into that when I can get a chance.

JohnCaccavale avatar Mar 21 '19 03:03 JohnCaccavale

I wonder who is assignees and managing this repo?

ShawnBaek avatar Mar 30 '19 06:03 ShawnBaek

@ShawnBaek see https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1356

acinader avatar Mar 30 '19 06:03 acinader

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@mtrezza I see this PR is still available. Please let me know if you would be able to review and if there's anything else that would be needed from me.

JohnCaccavale avatar Jan 14 '22 03:01 JohnCaccavale

@mrmarcsmith could I add you to the team of Parse ObjC SDK reviewers? The group gets a notification when a PR is ready for review.

mtrezza avatar Jan 15 '22 13:01 mtrezza

Yeah, I wasn't sure about how to setup a test for this type of scenario when I originally opened up the PR either. But, this fix had addressed my issue, which I've been using in my local branch since the PR was originally opened. Quite some time now. I would be concerned if this fix broke existing tests, which currently I'm seeing one macOS test failing, but not sure if thats a flaky test or not.

Failing tests:
	ParseUnitTests-macOS:
		-[AnonymousUtilsTests testLogInViaBlock]

JohnCaccavale avatar Jan 16 '22 03:01 JohnCaccavale

Let's see whether the test passes in rerun, but I think this is good to merge also without test which may be difficult to implement.

mtrezza avatar Jan 16 '22 10:01 mtrezza

The same test keeps failing, but I noticed that it also failed before this PR, so I think we are good to merge.

mtrezza avatar Jan 16 '22 11:01 mtrezza

I think we can merge this, but the carthage CI is currently failing, so we may have to address this first.

mtrezza avatar Jul 26 '22 12:07 mtrezza

@mtrezza Just saw your message, I'm off from work today, let me know if there's anything I can do. I see there was a recently a PR merged with regards to increasing the time out of the carthage CircleCI timeout, I'm hoping that would help address the failure being shown here.

I pulled in your latest changes with regards to that fix that was merged. The tasks are currently running, will keep an eye on that status of them.

JohnCaccavale avatar Jul 29 '22 14:07 JohnCaccavale

I just approved the workflow to run, let's see...

mtrezza avatar Jul 29 '22 21:07 mtrezza

I will reformat the title to use the proper commit message syntax.

Carthage support has been removed, so if the CI passes, we can merge this finally

mtrezza avatar Jan 30 '23 03:01 mtrezza

@mtrezza great! I won't have to keep applying my patch any longer 😂. Hopefully the tests will pass. 🤞

JohnCaccavale avatar Jan 30 '23 03:01 JohnCaccavale

I will reformat the title to use the proper commit message syntax.

🎉 This change has been released in version 2.0.2

parseplatformorg avatar Jan 30 '23 11:01 parseplatformorg