Parse-SDK-JS
Parse-SDK-JS copied to clipboard
fix: allow `Parse.Cloud.beforeSubscribe` rejections to be caught by `ParseQuery.subscribe`
New Pull Request Checklist
- [x] I am not disclosing a vulnerability.
- [x] I am creating this PR in reference to an issue.
Issue Description
Cloud errors thrown from beforeConnect and beforeSubscribe will now catch, just like errors from query.find
Related issue: #1489
Approach
Throws error to subscription promise if error occurs
TODOs before merging
- [x] Add tests
Thanks for opening this pull request!
- π We are excited about your hands-on contribution!
Since this is a breaking change, how would you like to proceed - add a temporary Parse Server option (or maybe there is an alternative?) or wait to merge until Parse Server 6?
Which approach do you think is best? Itβs not a major issue so perhaps we can wait
Can you think of a way to support both for a while without making it a breaking change or adding a Parse Server option? Otherwise up to you, whatever you think is best.
Should we add this as a feature or fix? The issue is currently classified as feature.
@dblythy @mtrezza Can we get this into the 4.0.0 release?
That would be good
I will reformat the title to use the proper commit message syntax.
Codecov Report
Base: 99.93% // Head: 99.89% // Decreases project coverage by -0.03% :warning:
Coverage data is based on head (
e062596) compared to base (bc04b4b). Patch coverage: 81.81% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## alpha #1490 +/- ##
==========================================
- Coverage 99.93% 99.89% -0.04%
==========================================
Files 61 61
Lines 5966 5973 +7
Branches 1366 1367 +1
==========================================
+ Hits 5962 5967 +5
- Misses 4 6 +2
| Impacted Files | Coverage Ξ | |
|---|---|---|
| src/LiveQueryClient.js | 98.99% <81.81%> (-1.01%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Yes, that sounds good to me
π This change has been released in version 4.0.0-alpha.2
The label state:released-alpha cannot be used in combination with state:breaking.
π This change has been released in version 4.0.0-beta.1
π This change has been released in version 4.0.0