Parse-SDK-Flutter icon indicating copy to clipboard operation
Parse-SDK-Flutter copied to clipboard

feat: add query constraint `wherePolygonContains` to determine whether a point in within a polygon

Open Paul0Cesar opened this issue 3 years ago • 6 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Create a new constraint to check if Polygon contains the geopoint

Related issue: #777

Approach

create a new method to add polygon constraint in query

TODOs before merging

  • [ ] Add changes to documentation (guides, repository pages, in-code descriptions)

Paul0Cesar avatar Jul 18 '22 17:07 Paul0Cesar

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Could you add a test?

mtrezza avatar Jul 20 '22 11:07 mtrezza

@parse-community/flutter-sdk-review could someone please review this?

mtrezza avatar Aug 18 '22 19:08 mtrezza

Codecov Report

Base: 15.13% // Head: 15.83% // Increases project coverage by +0.70% :tada:

Coverage data is based on head (45a7056) compared to base (7f24fb2). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 45a7056 differs from pull request most recent head 4ea2f2c. Consider uploading reports for the commit 4ea2f2c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   15.13%   15.83%   +0.70%     
==========================================
  Files          47       47              
  Lines        2855     2860       +5     
==========================================
+ Hits          432      453      +21     
+ Misses       2423     2407      -16     
Impacted Files Coverage Δ
packages/dart/lib/src/network/parse_query.dart 22.31% <100.00%> (+1.57%) :arrow_up:
packages/dart/lib/src/utils/parse_decoder.dart 58.49% <0.00%> (+20.75%) :arrow_up:
packages/dart/lib/src/objects/parse_geo_point.dart 45.45% <0.00%> (+45.45%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 18 '22 19:08 codecov[bot]

Could you take a look at the failing lint test?

@mtrezza , sorry for the late answer, I fix the lint error

Paul0Cesar avatar Sep 05 '22 13:09 Paul0Cesar

Thanks @Paul0Cesar, all tests pass. Let's wait for a review by @parse-community/flutter-sdk-review to merge this.

mtrezza avatar Sep 09 '22 17:09 mtrezza

@mbfakourii Thanks for reviewing this.

@Paul0Cesar To merge this, could you add the change log entry and bump the version by a minor version number? It seems this is only related to the dart package, so the change log and version number only needs to be changed there.

mtrezza avatar Nov 28 '22 23:11 mtrezza

@mtrezza , sorry for the late answer, I merge the master branch, fix the constant SINGLE QUERY not using _SINGLE_QUERY, and change the version

Paul0Cesar avatar Jan 18 '23 23:01 Paul0Cesar

@mbfakourii, I change the code formatting, can you check again?

Paul0Cesar avatar Jan 19 '23 13:01 Paul0Cesar

@mtrezza , done, can you check? :rocket:

Paul0Cesar avatar Jan 21 '23 15:01 Paul0Cesar