Parse-SDK-Flutter
Parse-SDK-Flutter copied to clipboard
feat: add query constraint `wherePolygonContains` to determine whether a point in within a polygon
New Pull Request Checklist
- [x] I am not disclosing a vulnerability.
- [x] I am creating this PR in reference to an issue.
Issue Description
Create a new constraint to check if Polygon contains the geopoint
Related issue: #777
Approach
create a new method to add polygon constraint in query
TODOs before merging
- [ ] Add changes to documentation (guides, repository pages, in-code descriptions)
Thanks for opening this pull request!
- 🎉 We are excited about your hands-on contribution!
Could you add a test?
@parse-community/flutter-sdk-review could someone please review this?
Codecov Report
Base: 15.13% // Head: 15.83% // Increases project coverage by +0.70% :tada:
Coverage data is based on head (
45a7056) compared to base (7f24fb2). Patch coverage: 100.00% of modified lines in pull request are covered.
:exclamation: Current head 45a7056 differs from pull request most recent head 4ea2f2c. Consider uploading reports for the commit 4ea2f2c to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 15.13% 15.83% +0.70%
==========================================
Files 47 47
Lines 2855 2860 +5
==========================================
+ Hits 432 453 +21
+ Misses 2423 2407 -16
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/dart/lib/src/network/parse_query.dart | 22.31% <100.00%> (+1.57%) |
:arrow_up: |
| packages/dart/lib/src/utils/parse_decoder.dart | 58.49% <0.00%> (+20.75%) |
:arrow_up: |
| packages/dart/lib/src/objects/parse_geo_point.dart | 45.45% <0.00%> (+45.45%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Could you take a look at the failing lint test?
@mtrezza , sorry for the late answer, I fix the lint error
Thanks @Paul0Cesar, all tests pass. Let's wait for a review by @parse-community/flutter-sdk-review to merge this.
@mbfakourii Thanks for reviewing this.
@Paul0Cesar To merge this, could you add the change log entry and bump the version by a minor version number? It seems this is only related to the dart package, so the change log and version number only needs to be changed there.
@mtrezza , sorry for the late answer, I merge the master branch, fix the constant SINGLE QUERY not using _SINGLE_QUERY, and change the version
@mbfakourii, I change the code formatting, can you check again?
@mtrezza , done, can you check? :rocket: