Parse-SDK-Flutter icon indicating copy to clipboard operation
Parse-SDK-Flutter copied to clipboard

Use all parameters of ParseLiveGridWidget

Open fischerscode opened this issue 3 years ago • 3 comments

New Feature / Enhancement Checklist

Current Limitation

Some of the parameters/attributes of the ParseLiveGridWidget are not used.

Feature / Enhancement Description

We should use all the parameters and deprecate those that can't be used. Additionally we should 'forward' every parameter of the GridView.

Example Use Case

scrollDirection: Axis.horizontal (See #740)

Alternatives / Workarounds

n/a

fischerscode avatar Jun 01 '22 16:06 fischerscode

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

In the implementation scroll direction was never added that’s why I did a pull request.

GridView.builder( //////////it should say here scrollDirection: widget.scrolDirection////////// itemCount: liveGrid.size, gridDelegate: SliverGridDelegateWithFixedCrossAxisCount( crossAxisCount: widget.crossAxisCount, crossAxisSpacing: widget.crossAxisSpacing, mainAxisSpacing: widget.mainAxisSpacing, childAspectRatio: widget.childAspectRatio),

pastordee avatar Jun 01 '22 17:06 pastordee

Same for scrollPhysics, scrollController, shrinkWrap... Your PR got closed since we deleted the development branch. It's not because of your changes.

fischerscode avatar Jun 01 '22 19:06 fischerscode