Parse-SDK-Android icon indicating copy to clipboard operation
Parse-SDK-Android copied to clipboard

feat: Add idempotency feature to detect duplicate requests due to network conditions

Open DrMimik opened this issue 2 years ago • 6 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Requests are duplicated on slow internet connections and during network interruptions.

Closes: #764

Approach

Add idempotency requestId header for client requests to enforce server side idempotency middleware on selected routes..

TODOs before merging

  • [x] Add tests
  • [ ] Add changes to documentation (guides, repository pages, in-code descriptions)

DrMimik avatar Mar 16 '23 11:03 DrMimik

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

I will reformat the title to use the proper commit message syntax.

Should I force push the first commit? or use a new commit?.

ghost avatar Mar 17 '23 09:03 ghost

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (83aec68) to head (039d197). Report is 1 commits behind head on master.

:exclamation: Current head 039d197 differs from pull request most recent head 76673eb

Please upload reports for the commit 76673eb to get more accurate results.

Files Patch % Lines
...arse/src/main/java/com/parse/ParseRESTCommand.java 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1190    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         124     122     -2     
  Lines       10076    9973   -103     
  Branches     1359    1345    -14     
=======================================
+ Misses      10076    9973   -103     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 19 '23 13:03 codecov[bot]

Should I force push the first commit? or use a new commit?.

New commit is preferable to track changes and reviewing it easily. Hoping to get this merged.

azlekov avatar May 16 '23 07:05 azlekov

@mtrezza Looks like this is ready for review

dplewis avatar Jun 07 '24 17:06 dplewis

@parse-community/android-sdk anyone wants to pick this up and submit a new PR? It seems this was almost ready for merge, except for lint issues.

mtrezza avatar Aug 05 '24 14:08 mtrezza

Hi, I am a new contributor, I would love to continue on this PR

abubkr-hago avatar Aug 14 '24 14:08 abubkr-hago

Hi, I am a new contributor, I would love to continue on this PR

That would be great!.

rommansabbir avatar Aug 14 '24 15:08 rommansabbir

Sure, please go ahead.

mtrezza avatar Aug 14 '24 15:08 mtrezza