Parse-SDK-Android
Parse-SDK-Android copied to clipboard
feat: Add idempotency feature to detect duplicate requests due to network conditions
New Pull Request Checklist
- [x] I am not disclosing a vulnerability.
- [x] I am creating this PR in reference to an issue.
Issue Description
Requests are duplicated on slow internet connections and during network interruptions.
Closes: #764
Approach
Add idempotency requestId header for client requests to enforce server side idempotency middleware on selected routes..
TODOs before merging
- [x] Add tests
- [ ] Add changes to documentation (guides, repository pages, in-code descriptions)
Thanks for opening this pull request!
- 🎉 We are excited about your hands-on contribution!
I will reformat the title to use the proper commit message syntax.
Should I force push the first commit? or use a new commit?.
Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
83aec68) to head (039d197). Report is 1 commits behind head on master.
:exclamation: Current head 039d197 differs from pull request most recent head 76673eb
Please upload reports for the commit 76673eb to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| ...arse/src/main/java/com/parse/ParseRESTCommand.java | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1190 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 124 122 -2
Lines 10076 9973 -103
Branches 1359 1345 -14
=======================================
+ Misses 10076 9973 -103
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Should I force push the first commit? or use a new commit?.
New commit is preferable to track changes and reviewing it easily. Hoping to get this merged.
@mtrezza Looks like this is ready for review
@parse-community/android-sdk anyone wants to pick this up and submit a new PR? It seems this was almost ready for merge, except for lint issues.
Hi, I am a new contributor, I would love to continue on this PR
Hi, I am a new contributor, I would love to continue on this PR
That would be great!.
Sure, please go ahead.