coda-js icon indicating copy to clipboard operation
coda-js copied to clipboard

Push Buttons

Open phlexib opened this issue 5 years ago • 4 comments

I'd like to add the Push a Button. Should it be part of the v1-migration branch or a new one ?

phlexib avatar Jul 29 '20 15:07 phlexib

Thanks for creating your first issue for coda-js and contributing!

github-actions[bot] avatar Jul 29 '20 15:07 github-actions[bot]

@phlexib Sounds great! I think it depends on when you'd like it merged and usable. Since it may be a couple weeks until the v1 migration is complete, perhaps you'd like to add it to the master branch. It would need to be updated to match the new Coda API version though, so it might take double the work.

I recommend adding the pushButton() method to the general Coda class and also the consecutive Doc, Table, and Row models so that we keep the eloquent API structure. If you're unsure what I mean, just ask!

parker-codes avatar Jul 29 '20 15:07 parker-codes

@parker-codes I think I get it. It will follow the https://coda.io/developers/apis/v1#operation model. I'll work on it on a new branch on my fork for now, as I'm already using the v1 api. It shouldn't be too much hassle to bring it when v1-migration is done.

phlexib avatar Jul 29 '20 15:07 phlexib

@phlexib Last night I tagged the release of v4.0.0, so you can add this to the updated master branch.

parker-codes avatar Aug 12 '20 15:08 parker-codes