Skip slot before creating inherent data providers during major sync

[LGLO]

Description

Moves create_inherent_data_provider after checking if major sync is in progress.

Integration

Change is internal to sc-consensus-slots. It should be no-op unless someone is using fork of this SDK.

Review Notes

Motivation for this change is to avoid calling create_inherent_data_providers if it's result is going to be discarded anyway during major sync. This has potential to speed up node operations during major sync by not calling possibly expensive create_inherent_data_provider.

TODO: labels T0-node D0-simple TODO: there is no tests for Slots, should I add one for this case?

Checklist

• [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above.
• [ ] My PR follows the labeling requirements of this project (at minimum one label for T required)
  • External contributors: ask maintainers to put the right label on your PR.
• [ ] I have made corresponding changes to the documentation (if applicable)
• [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable 2/3 Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7000829

[skunert]

bot fmt

[command-bot[bot]]

@skunert https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7004354 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-6bde3549-dd2f-4ab6-8352-d53a6613d0a4 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot[bot]]

@skunert Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7004354 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7004354/artifacts/download.

[bkchr]

@LGLO please merge master and run cargo fmt. Ty

[github-actions[bot]]

Review required! Latest push from author must always be reviewed

[LGLO]

@bkchr Done, sorry for delay, I was AFK for few days.