polkadot-sdk icon indicating copy to clipboard operation
polkadot-sdk copied to clipboard

Assets: can_decrease/increase for destroying asset is not successful

Open muharem opened this issue 1 year ago • 2 comments

Functions can_decrease and can_increase do not return successful consequence results for assets undergoing destruction; instead, they return the UnknownAsset consequence variant.

This update aligns their behavior with similar functions, such as reducible_balance, increase_balance, decrease_balance, and burn, which return an AssetNotLive error for assets in the process of being destroyed.

muharem avatar Feb 12 '24 08:02 muharem

@muharem what is the status of this pr?

bkchr avatar May 17 '24 11:05 bkchr

@muharem what is the status of this pr?

I did add it to the backlog for audit. But it is ready to be merged.

muharem avatar May 17 '24 12:05 muharem

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-clippy Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6641273

paritytech-cicd-pr avatar Jul 05 '24 15:07 paritytech-cicd-pr

bot merge

muharem avatar Jul 07 '24 10:07 muharem

@muharem bot merge and bot rebase are not supported anymore. Please use native Github "Auto-Merge" and "Update Branch" buttons instead. image

command-bot[bot] avatar Jul 07 '24 10:07 command-bot[bot]

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/discussion-treating-changes-in-dispatchable-function-errors-as-breaking-changes/11222/1

Polkadot-Forum avatar Dec 21 '24 09:12 Polkadot-Forum