polkadot-sdk
polkadot-sdk copied to clipboard
Assets: can_decrease/increase for destroying asset is not successful
Functions can_decrease and can_increase do not return successful consequence results for assets undergoing destruction; instead, they return the UnknownAsset consequence variant.
This update aligns their behavior with similar functions, such as reducible_balance, increase_balance, decrease_balance, and burn, which return an AssetNotLive error for assets in the process of being destroyed.
@muharem what is the status of this pr?
@muharem what is the status of this pr?
I did add it to the backlog for audit. But it is ready to be merged.
The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-clippy Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6641273
bot merge
@muharem bot merge and bot rebase are not supported anymore. Please use native Github "Auto-Merge" and "Update Branch" buttons instead.
This pull request has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/discussion-treating-changes-in-dispatchable-function-errors-as-breaking-changes/11222/1