parity-wasm icon indicating copy to clipboard operation
parity-wasm copied to clipboard

Published 20 hours ago • verified publisher icon paritytech

Fix testsuite on windows

Open devashishdxt opened this issue 3 years ago • 4 comments

Testsuite fails on windows because of manual filepath handling. Fixed it by using std::path::Path instead of str.

devashishdxt avatar Jul 18 '22 12:07 devashishdxt

The clippy issue is not related to this PR. I'm not sure if I should fix it in this PR?

devashishdxt avatar Jul 18 '22 12:07 devashishdxt

@pepyakin Can this be merged?

devashishdxt avatar Aug 02 '22 08:08 devashishdxt

technically we need two thumbs up, @athei r?

pepyakin avatar Aug 02 '22 09:08 pepyakin

The clippy issue is not related to this PR. I'm not sure if I should fix it in this PR?

Yes please fix the clippy issue. Then I merge Thanks.

athei avatar Aug 03 '22 08:08 athei