Faidon Liambotis

Results 129 comments of Faidon Liambotis

I still think this needs to happen and I'm happy to merge dev/rebase if/when required, but it'd be good to hear from a maintainer before I put more work into...

Just a drive-by comment but note for posterity that there are multiple out-of-tree efforts to implement this functionality: geoffdavis/esphome-mitsubishiheatpump#131 is a good resource documenting many of the forks. I think...

OK this may sound silly, but how do I report bugs? I can respond to issues on `muart-group/esphome` (and I've already done that on one) but it seems I cannot...

There are at least 6 different ESPHome components implementing this functionality ([geoffdavis/esphome-mitsubishiheatpump](https://github.com/geoffdavis/esphome-mitsubishiheatpump), [wrouesnel/esphome-mitsubishiheatpump](https://github.com/wrouesnel/esphome-mitsubishiheatpump), [echavet/MitsubishiCN105ESPHome](https://github.com/echavet/MitsubishiCN105ESPHome), [dark-nico/esphome-mitsubishiheatpump](https://github.com/dark-nico/esphome-mitsubishiheatpump), PR #5265, MUART). Many of them forks of each other, and some leverage the Swicago...

+1 this is kind of annoying :) Also see #2476 and in particular https://github.com/esphome/feature-requests/issues/2476#issuecomment-1844034117 which I believe is describing the same issue (although I find your example quite helpful in...

Thank you so much for the blazingly fast response! I don't have any good ideas on how to catch that kind of thing with CI :/ I'll think about it....

> Thank you so much for the blazingly fast response! I don't have any good ideas on how to catch that kind of thing with CI :/ I'll think about...

I see a few things implemented already in modmachine.c, like machine.idle() etc. Do you mean that it wouldn't make sense to implement this kind of thing in C, but instead...

> This one-line, eight-character simple patch is exactly what we needed, even without being tested. Thank you! (Well, err, I guess we just tested it) Thank you for testing this...