reth

reth copied to clipboard

Discussion: how to refactor storage libraries

1

The structure of storage related libraries are now: * `crates` * `codecs` * `db` * `libmdbx-rs` * `interfaces` (Database stuff becomes bigger and bigger, it probably deserves a standalone lib...

rakita

Our current priority is to achieve **full sync from genesis**. The state of progress is as follows: - [x] Generic headers & block bodies downloaders - [x] Generic database &...

akirillo

As the Execution stage needs real data to be tested `ethereum/test` chain tests gives us good amount of them.

rakita

mdbx does have support for it, it just needs to be added to `DbDupCursorRO` and `DbCursorRO`. It would make iteration over some tables easier.

rakita

Implement roundtrip tests for every message type

2

Bugs like #324 would be easily detected by roundtrip encoding and decoding tests for message types. This bug can be pretty severe, and would lead to kicking other reth peers...

Rjected

- [ ] add config option for blocking IPs in order to reject incoming connections - [ ] add peerId blocklist

mattsse

RLP decoding errors have been more common, so it should help to trace raw network messages if a call to `Decodable::decode` fails.

Rjected

ref https://github.com/foundry-rs/reth/pull/319 - [ ] add separate config option, like bootnodes, but nodes that we always want to connect to.

mattsse

- [ ] Add options to `NetworkConfig` So that we can easily configure different networks etc. https://github.com/foundry-rs/reth/blob/5c8b64a6cbda63df3b8b2c4ec3ced06c1a7b361b/crates/net/network/src/session/mod.rs#L109-L113

mattsse

Pre-open source checklist

5

A few things we need to sort out before open sourcing: - [x] Code of conduct - [x] Contributing guidelines - [x] Issue and PR templates - [ ] Good...

onbjerg