reth icon indicating copy to clipboard operation
reth copied to clipboard

add `use_self` clippy lint

Open tcoratger opened this issue 1 year ago • 1 comments

  • use_self clippy lint checks for unnecessary repetition of structure name when a replacement with Self is applicable.
  • Why is this bad?
    • Unnecessary repetition. Mixed use of Self and struct name feels inconsistent.

tcoratger avatar May 20 '24 15:05 tcoratger

please remove all semicolons, these should not be allowed with our policy to use cargo +nightly fmt. make pr may get rid of them, mind trying that?

done

tcoratger avatar May 20 '24 20:05 tcoratger

lgtm,

this could perhaps result in a few conflicts, but those can be easily resolved

I'm keeping this open, because we're about to merge a bunch of stuff from devnet-0 once stabilized, we can easily rebase this pr

Yes, please let me know when you are able to merge so that I fix conflicts and we directly merge to avoid further conflicts :)

tcoratger avatar May 21 '24 09:05 tcoratger

@tcoratger as promised a ton of conflicts hehe

maybe it's easier to start over, does cargo --fix apply these automatically?

mattsse avatar May 29 '24 11:05 mattsse

@tcoratger as promised a ton of conflicts hehe

maybe it's easier to start over, does cargo --fix apply these automatically?

No problem, done :)

tcoratger avatar May 29 '24 12:05 tcoratger