reth
reth copied to clipboard
add `use_self` clippy lint
use_selfclippy lint checks for unnecessary repetition of structure name when a replacement withSelfis applicable.- Why is this bad?
- Unnecessary repetition. Mixed use of
Selfand struct name feels inconsistent.
- Unnecessary repetition. Mixed use of
please remove all semicolons, these should not be allowed with our policy to use
cargo +nightly fmt.make prmay get rid of them, mind trying that?
done
lgtm,
this could perhaps result in a few conflicts, but those can be easily resolved
I'm keeping this open, because we're about to merge a bunch of stuff from devnet-0 once stabilized, we can easily rebase this pr
Yes, please let me know when you are able to merge so that I fix conflicts and we directly merge to avoid further conflicts :)
@tcoratger as promised a ton of conflicts hehe
maybe it's easier to start over, does cargo --fix apply these automatically?
@tcoratger as promised a ton of conflicts hehe
maybe it's easier to start over, does cargo --fix apply these automatically?
No problem, done :)