reth icon indicating copy to clipboard operation
reth copied to clipboard

Published 20 hours ago • verified publisher icon paradigmxyz

Support DNS resolution for bootnode URL

Open Rjected opened this issue 1 year ago • 1 comments

Geth parses enode addrs here: https://github.com/ethereum/go-ethereum/blob/74edc9386495f0ff44d68bf6e237a69f27021144/p2p/enode/urlv4.go#L72-L81

which does resolution here: https://github.com/ethereum/go-ethereum/blob/74edc9386495f0ff44d68bf6e237a69f27021144/p2p/enode/urlv4.go#L129-L137

We should support DNS resolution for bootnode enode URLs, although we should:

  • first parse, with a string fallback in case it is a domain and not an IP
  • attempt to resolve the string fallback later, with a timeout

Rjected avatar May 09 '24 18:05 Rjected

@Rjected did you want any help with your PR for this? Happy to help, have worked on similar stack in geth.

sergerad avatar May 17 '24 21:05 sergerad