reth icon indicating copy to clipboard operation
reth copied to clipboard

`max_gas_limit` from the basic payload builder is currently ignored

Open ralexstokes opened this issue 1 year ago • 1 comments

Describe the feature

Refer: https://github.com/paradigmxyz/reth/blob/cf6d34cf3da62704ebcbfe74d953249727c3d069/crates/payload/basic/src/lib.rs#L246

This field currently has no effect on the payload build process (and then I also wonder why the CLI arg is exposed).

I would suggest to either:

  1. remove field (and possibly the CLI arg)
  2. add comment just to make it clear this is currently ignored
  3. support a local gas target when building

(3) is probably where this project wants to eventually go, although the fix is not as simple as just routing the CLI param to the relevant payload builder as each block has to be within some fixed bounds of the parent gas limit (and so we would need a little bit more computation when making the payload attributes or payload config).

Additional context

No response

ralexstokes avatar Apr 28 '24 15:04 ralexstokes

This issue is stale because it has been open for 21 days with no activity.

github-actions[bot] avatar May 20 '24 01:05 github-actions[bot]

This issue was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar May 27 '24 01:05 github-actions[bot]