reth icon indicating copy to clipboard operation
reth copied to clipboard

feat(storage): custom tables

Open Vid201 opened this issue 1 year ago • 2 comments

Addresses #4546

This is a first draft how to support custom tables. Any feedback highly appreciated (or if this approach is not good and some other is preffered)

Example in the action:

  • https://github.com/silius-rs/silius/blob/chore/reth_db/crates/mempool/src/database/tables.rs
  • https://github.com/silius-rs/silius/blob/chore/reth_db/bin/silius/src/bundler.rs#L252

Vid201 avatar Apr 23 '24 21:04 Vid201

hmm, what's your use case for this? adding new tables to the existing DB?

we don't really want to open this up becomes then it becomes harder to transition to a new db in the future

The use case is to use crate reth_db for database in our project. But we are not using the same tables as reth node, but we have some custom tables (https://github.com/silius-rs/silius/blob/chore/reth_db/crates/mempool/src/database/tables.rs)

If this is not the intended use of reth_db, no problem, we'll use something else

Vid201 avatar Apr 26 '24 10:04 Vid201

reopening this, because this is still something we want to support and this is likely useful as a reference FYI @onbjerg

mattsse avatar Jul 26 '24 12:07 mattsse

I'm closing this now that we have a path forward here

ref #13130

Awesome! I'll take a look at new approach

Vid201 avatar Dec 06 '24 11:12 Vid201

not quite there yet, but almost

mattsse avatar Dec 07 '24 12:12 mattsse