reth icon indicating copy to clipboard operation
reth copied to clipboard

move `ChunkedFileReader` type into `FileClient` type

Open emhane opened this issue 1 year ago • 1 comments

Describe the feature

Incorporate the ChunkedFileReader into the FileClient, as opposed to ChunkedFileReader::next_chunk returning a new FileClient. Instead, a new chunk is read upon call to <FileClient as HeadersClient>::get_headers_with_priority, if the FileClient has no more headers in its map.

This requires modifying the ImportCommand. A new arg is needed --tip <block-hash-sync-target>, which must be passed to the FileClient. The pipeline can then be built once.

Additional context

As a side effect, this will enable ETL wrt to the whole file on chunked reads.

No response

emhane avatar Apr 15 '24 12:04 emhane

This issue is stale because it has been open for 21 days with no activity.

github-actions[bot] avatar May 18 '24 01:05 github-actions[bot]

headers downloader gets tip to genesis, makes this more complex, since requires reading the file in reverse. right @joshieDo ?

emhane avatar May 21 '24 15:05 emhane

we've changed this quite a bit since and no longer encourage pre bedrock support.

closing this for now because I think we can revisit this entire impl

mattsse avatar Mar 03 '25 10:03 mattsse