reth icon indicating copy to clipboard operation
reth copied to clipboard

chore: refactor poll_reserve logic to be a seperate function

Open mw2000 opened this issue 1 year ago • 7 comments

Separating the poll_reserve logic out into a new function on the ExExHandle level that the manager can call.

Fixes: #7570

mw2000 avatar Apr 12 '24 21:04 mw2000

Ahh just saw #7609 from mattsse. Apologies for the duplicate effort

mw2000 avatar Apr 12 '24 22:04 mw2000

ah I forgot that there was an issue for this already -.-

do you want to continue this following my docs on #7609?

mattsse avatar Apr 12 '24 22:04 mattsse

@mattsse yeah would love to!

mw2000 avatar Apr 13 '24 08:04 mw2000

@mattsse solved most of your Todos. Not the most confident on the PR, but would love more insight/context. Also would love if there's any tests you suggest I can add for this to make it airtight

mw2000 avatar Apr 16 '24 05:04 mw2000

Hey guys, appreciate the comments. This gives a lot of context, thank you. I'll push an update to this today/tmrw

mw2000 avatar Apr 18 '24 15:04 mw2000

Hey @mw2000, what's the status on this? Something I can help with? 😄

onbjerg avatar Apr 24 '24 09:04 onbjerg

@onbjerg Added the changes that you and @mattsse discussed here. I think this one looks better, but I haven't been able to unit test it. Can you suggest what I can do to make sure the implementation is good? I think i understand high level what's happening, but would love to have tests that i can then run my implementation against.

mw2000 avatar Apr 25 '24 07:04 mw2000

reopened because this would be nice to have

mattsse avatar May 29 '24 09:05 mattsse

hey, I think something went wrong with merging or rebasing, since the diff is now huge, maybe it needs to be merged with main again?

Rjected avatar Jun 05 '24 19:06 Rjected

@Rjected yeah let me fix that, sorry picked this up after a while

mw2000 avatar Jun 05 '24 19:06 mw2000

Fixed, moved this back to draft, apologies for the pings here

mw2000 avatar Jun 05 '24 20:06 mw2000

Opening this back up.

With the progress on the repo since the last time i took a crack at this issue, it looks like I don't need to add much beyond the poll reserve function itself. Feel free to close unmerged if not needed anymore.

mw2000 avatar Jun 05 '24 21:06 mw2000