reth icon indicating copy to clipboard operation
reth copied to clipboard

Extend fork activation blocks data

Open klkvr opened this issue 1 year ago • 10 comments

Describe the feature

Extend https://github.com/paradigmxyz/reth/blob/main/crates/ethereum-forks/src/hardfork.rs with fork activation block numbers data for more chains.

This data is non-trivial to obtain, so comments/links to lists of hardfork->block mappings are appreciated as well even if you have no plans for creating a PR with those.

Especially useful would be data for Arbitrum and any other chains enabling Shanghai/Cancun support in the near future.

Additional context

No response

klkvr avatar Mar 11 '24 15:03 klkvr

Can I work on this? Which chains would be beneficial to add?

altugbakan avatar Mar 11 '24 16:03 altugbakan

arbitrum would be great

mattsse avatar Mar 11 '24 16:03 mattsse

So, I’ve started doing some research. Are Arbitrum One and its testnet sufficient, or should we consider Arbitrum Nova and others?

altugbakan avatar Mar 12 '24 13:03 altugbakan

happy to accept all :)

up to you how much you'd like to do, but one+testnet would be sufficient

mattsse avatar Mar 12 '24 14:03 mattsse

Quick update: I've found the corresponding upgrades (ArbOS 11 for Shangai, ArbOS 20 Atlas for Cancun), but I could not find the actual blocks where the upgrade has happened. They have the update information here, but there is no information on the block number, just the date. I'm continuing my research, but if there are any tips you would like to give, I'm open to them.

altugbakan avatar Mar 14 '24 10:03 altugbakan

you can try cast find-block <timestamp> to find the block that corresponds to a timestamp

mattsse avatar Mar 14 '24 12:03 mattsse

We don't support Arbitrum yet so not sure we should include this?

gakonst avatar Mar 16 '24 20:03 gakonst

We've discussed this in context of this being useful as a separate crate which we could also pull in as a foundry dep to address https://github.com/foundry-rs/foundry/issues/6228#issuecomment-1812843644 by determining spec for forked env.

Agreed that it'd be confusing to have arbitrum feature flag in any of Reth packages at this point

@mattsse wdyt?

klkvr avatar Mar 16 '24 23:03 klkvr

@mattsse think you should close this issue... (it's still in reth tracker)

mvares avatar Jul 19 '24 19:07 mvares

This issue is stale because it has been open for 21 days with no activity.

github-actions[bot] avatar Aug 10 '24 01:08 github-actions[bot]

This issue was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Aug 18 '24 01:08 github-actions[bot]