reth icon indicating copy to clipboard operation
reth copied to clipboard

Unblock `ActiveSession`

Open emhane opened this issue 1 year ago • 4 comments

Describe the feature

Extend pattern for unblocking futures/streams used in TransactionsManager (among others) to ActiveSession.

https://github.com/paradigmxyz/reth/pull/6590#issuecomment-1976570628

Additional context

No response

emhane avatar Mar 06 '24 15:03 emhane

@emhane Have you started working on this? If not, I'd like to fix it :)

int88 avatar Mar 28 '24 01:03 int88

hey @int88 ! I did already start this, it's a very complex task that requires modelling the flow of all nested streams in the ActiveSession future - I've done that first part, and started with implementation

emhane avatar Mar 28 '24 13:03 emhane

Yes, I found it too. It seems that the existing process cannot be simply applied :)

int88 avatar Mar 29 '24 01:03 int88

ordering of the nested streams, and setting the budget for each nested stream, that's the complex part. it's also fun though :)

emhane avatar Mar 29 '24 11:03 emhane

this type already has preemption budget for incoming messages

https://github.com/paradigmxyz/reth/blob/d2010d5d25a2fb98699c00418070304348107699/crates/net/network/src/session/active.rs#L571-L579

mattsse avatar Aug 20 '24 09:08 mattsse