reth icon indicating copy to clipboard operation
reth copied to clipboard

chore: move `AccountWriter` methods to `HashingWriter` and `HistoryWriter`

Open joshieDo opened this issue 2 years ago • 1 comments

Follow up on #3285

HashingWriter (will move the account methods in another PR as discussed )
HistoryWriter(will move the account methods in another PR as discussed )

Moves the methods and remove AccountWriter

joshieDo avatar Jun 22 '23 15:06 joshieDo

Codecov Report

Merging #3332 (b76b8b7) into main (d60aef5) will decrease coverage by 0.03%. The diff coverage is 96.03%.

@@            Coverage Diff             @@
##             main    #3332      +/-   ##
==========================================
- Coverage   69.51%   69.49%   -0.03%     
==========================================
  Files         535      535              
  Lines       71838    71837       -1     
==========================================
- Hits        49941    49925      -16     
- Misses      21897    21912      +15     
Flag Coverage Δ
integration-tests 16.32% <0.00%> (-0.01%) :arrow_down:
unit-tests 64.54% <96.03%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/staged-sync/src/utils/init.rs 95.98% <ø> (ø)
crates/stages/src/stages/hashing_account.rs 95.91% <ø> (ø)
crates/stages/src/stages/index_account_history.rs 96.74% <ø> (ø)
crates/storage/provider/src/lib.rs 100.00% <ø> (ø)
crates/storage/provider/src/traits/account.rs 50.00% <ø> (+16.66%) :arrow_up:
crates/storage/provider/src/traits/hashing.rs 0.00% <ø> (ø)
crates/storage/provider/src/traits/history.rs 0.00% <ø> (ø)
...torage/provider/src/providers/database/provider.rs 74.85% <96.03%> (ø)

... and 10 files with indirect coverage changes

codecov[bot] avatar Jun 22 '23 16:06 codecov[bot]