reth icon indicating copy to clipboard operation
reth copied to clipboard

Published 20 hours ago • verified publisher icon paradigmxyz

Improve logging

Open 3alpha opened this issue 2 years ago • 1 comments

Describe the feature

This is probably matter of opinion, but p2p logging seems too noisy to me. For every peer connection there are two logs messages emitted, which seems much. Example:

2023-06-22T12:50:58.720451Z  INFO net: Session established remote_addr=IP:PORT client_version= peer_id=0xa7e6371700107bec6cfd7b31f06c3a938a284439a74c8f32afeb10368896f6532c12e734c66943a106168606b3f671f439be4ad129da816cd71cc935bbb403c5 total_active=80
2023-06-22T12:50:58.720509Z  INFO reth::cli: Peer connected connected_peers=80 peer_id=0xa7e6…03c5 best_block=0xd4e5…8fa3

Maybe it would be wise to introduce some granularity so that different log levels can be specified for different modules.

Additional context

No response

3alpha avatar Jun 22 '23 13:06 3alpha

2023-06-22T12:50:58.720451Z INFO net: Session established remote_addr=IP:PORT client_version= peer_id=0xa7e6371700107bec6cfd7b31f06c3a938a284439a74c8f32afeb10368896f6532c12e734c66943a106168606b3f671f439be4ad129da816cd71cc935bbb403c5 total_active=80

debatable whether we need this on INFO

we could change this to debug @onbjerg @Rjected ?

mattsse avatar Jun 22 '23 14:06 mattsse

Sure

onbjerg avatar Jun 25 '23 13:06 onbjerg

This was already fixed, see https://github.com/paradigmxyz/reth/blob/23a99d41643d3a432cae0f717c90451738ec2d51/bin/reth/src/node/events.rs#L106-L110

Please update your node

onbjerg avatar Jun 26 '23 16:06 onbjerg