reth icon indicating copy to clipboard operation
reth copied to clipboard

perf: only record return value if required

Open mattsse opened this issue 2 years ago • 2 comments

~~Blocked by https://github.com/bluealloy/revm/pull/509~~

this will only record the call's output if configured

prep for #3032

mattsse avatar Jun 06 '23 21:06 mattsse

Blocking PR merged, marking as unblocked @mattsse

onbjerg avatar Jun 08 '23 10:06 onbjerg

this is still blocked because revm has two branches and the feature we need here is on main but we pull in release/v25

mattsse avatar Jun 13 '23 11:06 mattsse

@onbjerg unblocked by copying the unreleased function to unblock this

mattsse avatar Jul 05 '23 13:07 mattsse

Codecov Report

Merging #3040 (a42fce5) into main (ceb4e35) will decrease coverage by 0.03%. The diff coverage is 5.88%.

Impacted file tree graph

Impacted Files Coverage Δ
...s/revm/revm-inspectors/src/tracing/builder/geth.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <ø> (ø)
crates/rpc/rpc/src/debug.rs 11.06% <0.00%> (ø)
crates/rpc/rpc/src/eth/revm_utils.rs 36.33% <0.00%> (-0.65%) :arrow_down:
crates/revm/revm-inspectors/src/tracing/config.rs 26.76% <33.33%> (+0.28%) :arrow_up:

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.10% <5.88%> (-0.02%) :arrow_down:
unit-tests 63.96% <5.88%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.41% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.91% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 95.09% <ø> (ø)
txpool 49.11% <ø> (-0.09%) :arrow_down:
networking 77.86% <ø> (-0.07%) :arrow_down:
rpc 58.02% <0.00%> (-0.02%) :arrow_down:
consensus 62.69% <ø> (ø)
revm 34.96% <14.28%> (+<0.01%) :arrow_up:
payload builder 6.83% <ø> (ø)
primitives 88.29% <ø> (+<0.01%) :arrow_up:

codecov[bot] avatar Jul 05 '23 13:07 codecov[bot]