`debug_traceTransaction` `enableReturnData` should be ignored for RPC responses

[mattsse]

Describe the feature

the response type StructLogRes doesn't even include a returnData field, and this is only used for local debugging.

It should simply be ignored so we don't capture return data that we don't need

it's only used for debug_standardTraceBlockToFile and debug_standardTraceBadBlockToFile rpc calls

TODO

• document extra fields in StructLog type (StructLogRes)
• ignore enableReturnData setting for regular debug_trace calls that return RPC

is this correct @shekhirin ?

Additional context

No response

[shekhirin]

Yes, that sounds right!

[github-actions[bot]]

This issue is stale because it has been open for 14 days with no activity.

[shekhirin]

@mattsse is this still relevant?

[mattsse]

yeah, the pr is still blocked because revm pr is not included in the patch. I could finish it though with some extra code though, I think I'll just do that

[github-actions[bot]]

This issue is stale because it has been open for 14 days with no activity.

[mattsse]

actually, since enableReturnData is opt-in, it would be more effort to remove support for it in the regular rpc calls