reth icon indicating copy to clipboard operation
reth copied to clipboard

Give more info in `web3_clientVersion`, particularly the commit hash

Open sslivkoff opened this issue 2 years ago • 4 comments

Describe the feature

For the web3_clientVersion rpc method:

  • erigon outputs erigon/2.43.0/linux-amd64/go1.20.3
  • reth outputs reth/v0.1.0/x86_64-unknown-linux-gnu

For reth it would be nice to include more info. Including a commit hash prefix would be extremely helpful, particularly since reth is under active development.

Getting fancy could maybe also include abbreviations of major compile flags or runtime cli args

Additional context

No response

sslivkoff avatar Jun 03 '23 21:06 sslivkoff

Down to tackle this if i can have some more information.

0xJepsen avatar Jun 10 '23 02:06 0xJepsen

I'm actually not sure about the commit hash, not sure we want to leak that. This usually mirrors the client version used in p2p

wdyt @gakonst

mattsse avatar Jun 10 '23 10:06 mattsse

Yes on same as p2p

gakonst avatar Jun 10 '23 21:06 gakonst

how about leaking the commit when it's not a tagged commit? that would be useful for dev situations but then only give tagged version # for most users

sslivkoff avatar Jun 15 '23 23:06 sslivkoff

This issue is stale because it has been open for 14 days with no activity.

github-actions[bot] avatar Jul 06 '23 02:07 github-actions[bot]