reth
reth copied to clipboard
Inconsistent {Head,Safe,Finalized} hive tests are failing
Describe the bug
These tests send an inconsistent ForkchoiceState with a known payload that belongs to a side chain as head, safe or finalized.
https://github.com/mattsse/hive/blob/master/simulators/ethereum/engine/suites/engine/tests.go#L1417-L1422
geth sends here
{"code":-38002,"message":"Invalid forkchoice state","data":{"err":"final block not in canonical chain"}}}
we're missing these checks before processing FCU
https://github.com/ethereum/go-ethereum/blob/73697529994e14996b7740730481e926d5ec3e40/eth/catalyst/api.go#L309-L317
Steps to reproduce
./hive --client reth --sim ethereum/engine --sim.limit "/Inconsistent Head in ForkchoiceState"
Node logs
No response
Platform(s)
No response
What version/commit are you on?
No response
Code of Conduct
- [X] I agree to follow the Code of Conduct