Remove references to transition ids

[petertdavies]

Describe the change

Transition ids were abolished and replaced with block numbers in #2275. However references to them still exist in docstrings and comments, which is quite confusing. For example the word "transition" appears 9 times in crates/storage/provider/src/post_state.rs.

Additional context

No response

[gakonst]

Yep - working on this next week.

[mattsse]

@onbjerg is this still the case?

[onbjerg]

Not in that file specifically, but transition IDs are still mentioned in function names and docs, e.g. here:

https://github.com/paradigmxyz/reth/blob/600f3eac8c494dfc10b628527ff87513e2381b7f/crates/storage/provider/src/providers/database/provider.rs#L258

https://github.com/paradigmxyz/reth/blob/600f3eac8c494dfc10b628527ff87513e2381b7f/crates/storage/provider/src/providers/database/provider.rs#L123

https://github.com/paradigmxyz/reth/blob/600f3eac8c494dfc10b628527ff87513e2381b7f/crates/storage/provider/src/providers/database/provider.rs#L285

[github-actions[bot]]

This issue is stale because it has been open for 14 days with no activity.

[github-actions[bot]]

This issue is stale because it has been open for 14 days with no activity.

[github-actions[bot]]

This issue is stale because it has been open for 21 days with no activity.

[github-actions[bot]]

This issue is stale because it has been open for 21 days with no activity.

[github-actions[bot]]

This issue was closed because it has been inactive for 7 days since being marked as stale.