reth
reth copied to clipboard
Makefile dependency issues: Missing checks for wget, cargo-nextest, and ef-tests
trafficstars
Describe the feature
The project Makefile assumes several dependencies are pre-installed without checking for their presence or providing clear error messages when they're missing. This causes confusing failures during build and test processes.
Additional context
When running certain Makefile targets (particularly make ef-tests and test-related targets), the build fails with unclear errors when dependencies are missing:
wget- Required for downloading Ethereum Foundation test vectorscargo-nextest- Required for running tests with the nexttest runner- EF test vectors - Required to be downloaded before running certain tests
These dependencies aren't explicitly checked before use, so users encounter cryptic errors like:
wget: command not foundcargo: 'nextest' is not a cargo commandTest suite path does not exist: "testing/ef-tests/ethereum-tests/..."
Proposed Solution
Update the Makefile to:
- Check for required dependencies before using them
- Install dependencies automatically when possible (for Cargo tools)
- Provide clear error messages when manual installation is needed
Additional Notes
- It would also be helpful to have a
make setuptarget that installs all required dependencies at once