reth icon indicating copy to clipboard operation
reth copied to clipboard

Keep revealed sparse trie paths on trie level

Open shekhirin opened this issue 9 months ago • 5 comments

Originally posted by @rkrasiuk in https://github.com/paradigmxyz/reth/pull/14370#discussion_r1949548483

Instead of keeping a list of revealed paths for account and storage tries separately in the SparseStateTrie struct https://github.com/paradigmxyz/reth/blob/477b747ef4e602af642d64ee778c5b4970685c16/crates/trie/sparse/src/state.rs#L29-L32 we can add a revealed field to the RevealedSparseTrie struct and check + track the revealed nodes in reveal_node https://github.com/paradigmxyz/reth/blob/477b747ef4e602af642d64ee778c5b4970685c16/crates/trie/sparse/src/trie.rs#L307

shekhirin avatar Feb 10 '25 17:02 shekhirin

What's the implication of this?

gakonst avatar Feb 10 '25 17:02 gakonst

This issue is stale because it has been open for 21 days with no activity.

github-actions[bot] avatar Mar 04 '25 02:03 github-actions[bot]

Hello!

Can i take this up?

ametel01 avatar Mar 28 '25 12:03 ametel01

@ametel01 sorry, just noticed this! Assigned, let me know if you're still interested in working on this task.

shekhirin avatar Apr 10 '25 15:04 shekhirin

Hello @shekhirin , can i look into this?

Ayushdubey86 avatar Apr 10 '25 18:04 Ayushdubey86