reth
reth copied to clipboard
paradigmxyz
feat(refractor): move imports to blockchain-tree-api crate
@mattsse, Do you prefer BlockBuffer copy or move entirely to blockchain-tree-api?
Do you prefer BlockBuffer copy or move entirely to blockchain-tree-api?
yeah for now that's the best solution because we currently use that in two places
There is a cyclic dependency issue when copying BlockBuffer to tree_api. reth-network => reth-provider => reth-blockchain-tree-api => reth_network reth_network is being used for BlockBuffer.
reth-network utilising reth-provider for tests and bench. test-utils should be fine as it is primary being used for tests, however the main issue is when using for bench.
I see, could you push your latest draft please, I believe we can work around this
There is a cyclic dependency issue when copying BlockBuffer to tree_api.
reth-network => reth-provider => reth-blockchain-tree-api => reth_networkreth_network is being used for BlockBuffer.reth-network utilising reth-provider for tests and bench.
test-utilsshould be fine as it is primary being used for tests, however the main issue is when using for bench.
These are the changes for now. I will push final changes once we passed the cyclic dependency issue.
From what I understand, as long as the dependency is optional, we can subscribe that dependency via the required-feature in cargo file. However, this is already the case in reth-network cargo file. I'm sure I'm missing something here. Please feel free to correct me.