ai-deadlines icon indicating copy to clipboard operation
ai-deadlines copied to clipboard

calendar off-by-one error

Open intrepidlemon opened this issue 1 year ago • 3 comments

image The calendar page seems to display conferences one day offset from their actual dates. This behavior is the same for conferences regardless of timezone.

intrepidlemon avatar Jan 28 '24 19:01 intrepidlemon

if it helps, I'm in the America/New_York timezone. I don't expect that I should be a day off from Vancouver Canada.

intrepidlemon avatar Jan 28 '24 20:01 intrepidlemon

Hi thanks for reporting this, it does seem to be a timezone issue as it shows correctly in London timezone. I'll look into this. Cheers!

andrewkuanop avatar Jan 29 '24 11:01 andrewkuanop

thank you, really appreciate it. I tried looking into it a bit:

Seems like this is where the start and end dates get parsed: https://github.com/paperswithcode/ai-deadlines/blob/597cc7d66f5f0146c9cee6e5c400a334435a1d7f/_includes/calendar.js#L120

Might be due to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse#non-standard_date_strings ?

I'm not entirely sure where timezones get mixed up in this loop though.

intrepidlemon avatar Feb 25 '24 23:02 intrepidlemon