terminus icon indicating copy to clipboard operation
terminus copied to clipboard

PHP 8.2 support

Open heddn opened this issue 3 years ago • 1 comments
trafficstars

Platform

( ) MacOS ( x) Linux ( ) Winderz

Installed Via

( ) Homebrew ( ) Apt Package ( X) Manually

PHP Version

( ) 7.4x ( ) 8.0 ( ) 8.1 (x) 8.2

Command Executed

Installing terminus, then installing secrets and rsync plugin fall on their face:

Deprecated: Creation of dynamic property Consolidation\AnnotatedCommand\Parser\Internal\BespokeDocBlockParser::$commandInfo is deprecated in phar:///var/www/html/terminus/vendor/consolidation/annotated-command/src/Parser/Internal/BespokeDocBlockParser.php on line 35

Deprecated: Creation of dynamic property Consolidation\AnnotatedCommand\Parser\Internal\BespokeDocBlockParser::$reflection is deprecated in phar:///var/www/html/terminus/vendor/consolidation/annotated-command/src/Parser/Internal/BespokeDocBlockParser.php on line 36
  curl -L https://github.com/pantheon-systems/terminus/releases/download/3.0.7/terminus.phar --output terminus\
  && chmod 755 terminus \
  && ./terminus self-update \
  && mv terminus /usr/local/bin/terminus \
  && terminus self:plugin:install terminus-secrets-plugin \
  && terminus self:plugin:install terminus-rsync-plugin

Expected behavior

I'm trying to get terminus to install on PHP 8.2, which just went ~beta2~RC01 recently.

Actual behavior

If your issue is with a command not working, please run the command again with the -vvv option (--debug in 0.x) and copy everything from the command down to the next prompt and paste it here between a pair of ``` marks.

heddn avatar Aug 05 '22 21:08 heddn

It looks like this might be resolved upstream now and we just need to pull in a newer version: https://github.com/consolidation/annotated-command/pull/271

heddn avatar Sep 13 '22 18:09 heddn

Thanks @heddn -- this is on our radar with the upcoming PHP 8.2 release!

scottbuscemi avatar Dec 01 '22 19:12 scottbuscemi

I ran into this today after updating Mac OS and Xcode.

$ terminus

PHP 8.2+ is not supported by this version of Terminus.
Check for new versions at https://github.com/pantheon-systems/terminus/releases

Set environment variable TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP to try continuing anyway.
Stopping.

$ which terminus
/opt/homebrew/bin/terminus
$ brew upgrade terminus
Warning: pantheon-systems/external/terminus 3.1.1 already installed
$ php --version
PHP 8.2.0 (cli) (built: Dec  9 2022 16:30:32) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.0, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.0, Copyright (c), by Zend Technologies
$ which php
/opt/homebrew/bin/php

YesCT avatar Dec 29 '22 16:12 YesCT

n.b. we have https://github.com/pantheon-systems/terminus/pull/2414, but we still need to make a release.

greg-1-anderson avatar Dec 29 '22 18:12 greg-1-anderson

It looks like #2414 was released in 3.1.2, so I think this can be closed now

G-Rath avatar Feb 09 '23 19:02 G-Rath

Thanks for the reminder @G-Rath. #2414 was included in https://github.com/pantheon-systems/terminus/compare/3.1.1...3.1.2.

CdrMarks avatar Feb 09 '23 22:02 CdrMarks