panodata-map-panel icon indicating copy to clipboard operation
panodata-map-panel copied to clipboard

Published 20 hours ago • verified publisher icon panodata

Add reversible legend option

Open matschaffer opened this issue 4 years ago • 6 comments

Fixes https://github.com/panodata/grafana-map-panel/issues/85

matschaffer avatar Dec 27 '20 06:12 matschaffer

Ah, just noticed the + and < need attention here as well.

matschaffer avatar Dec 27 '20 06:12 matschaffer

Ah nice. Now that I see which test handles this I’ll add something to test reversibility too.

matschaffer avatar Dec 27 '20 09:12 matschaffer

Dear Mat,

thanks a stack for this contribution.

Now that I see which test handles this I’ll add something to test reversibility too.

That would be super nice!

With kind regards, Andreas.

amotl avatar Dec 27 '20 09:12 amotl

Dear Mat,

do you also believe this patch would be ready to go? Currently, the PR is still in "Draft" state.

With kind regards, Andreas.

amotl avatar Jun 09 '21 23:06 amotl

I'd have to double check. I think it might have been failing tests last I looked, but it seems green here so not sure.

matschaffer avatar Jun 10 '21 00:06 matschaffer

Hi Mat,

indeed, the tests seem to have succeeded. So, maybe just let us remove the "Draft" flag and finally merge the patch?

With kind regards, Andreas.

amotl avatar Jul 22 '21 21:07 amotl