pallad icon indicating copy to clipboard operation
pallad copied to clipboard

Add a new route in Settings to display "Authorized zkApps"

Open mrcnk opened this issue 1 year ago • 1 comments

Acceptance Criteria

  • [ ] There is a new Settings item between Privacy and About called "Authorized zkApps".
  • [ ] When clicked, it opens a list of zkApps that wallet holder authorized with Wallet Connector.
  • [ ] The list contains items with:
    • zkApp name and icon (get it with https://api.dub.co/metatags?url=[ZKAPP_ORIGIN]).
    • zkApp origin.
    • Button to remove permission (XIcon from lucide-react).

Design

TBA

mrcnk avatar Aug 20 '24 18:08 mrcnk

/price 200

mrcnk avatar Aug 20 '24 18:08 mrcnk

I'll like to be assigned this

Myestery avatar Aug 22 '24 09:08 Myestery

Hi @Myestery, let me sort out the design for this, and I'll soon get back to you.

mrcnk avatar Aug 22 '24 09:08 mrcnk

@Myestery here you go: zkapps-settings zkapps-authorized

Tips: Icons are - app-window-mac and x from lucide-react.

mrcnk avatar Aug 24 '24 10:08 mrcnk

@Myestery to manage the permissions (list and delete on X clicked) you can use:

  • list: const { permissions } = await chrome.storage.local.get({ permissions: true })
  • delete: await chrome.storage.local.set({ permissions: [FILTERED_PERMISSIONS] })

mrcnk avatar Aug 24 '24 10:08 mrcnk

Thank you

Myestery avatar Aug 24 '24 10:08 Myestery

Please Review @mrcnk

Myestery avatar Aug 27 '24 00:08 Myestery

@all-contributors please add @Myestery for code

mrcnk avatar Aug 30 '24 20:08 mrcnk

@mrcnk

I've put up a pull request to add @Myestery! :tada:

allcontributors[bot] avatar Aug 30 '24 20:08 allcontributors[bot]

Hi @mrcnk I'm a little confused as to what the next step is regarding claiming the bounty payment

Myestery avatar Sep 02 '24 06:09 Myestery

Its part of Unrewarded issues on Astro Mina

Myestery avatar Sep 03 '24 12:09 Myestery

Hey @Myestery, I reached out to AstroMina and they will contact you directly soon reg. the bounty payout. There's a bug on the platform, and they have to handle it manually.

mrcnk avatar Sep 03 '24 13:09 mrcnk