pali

Results 504 comments of pali

Some random notes: * Squash fixup commits. Commits which fixes just another commits in this pull requests are not useful in git history. * Correct UDF is also with just...

* /etc/mtab does not have to be up-to-date, use /proc/mounts instead * on Linux 2.6+ you can atomically check if block device is not mounted && open it via O_EXCL...

O_EXCL should be used only for block devices on Linux. Use stat() for checking if path is block device, then do open() with or without O_EXCL (based on fact if...

Another thing which fsck should do: check if d-string and d-characters values are valid (+ ability to fix it).

Ad O_EXCL: mkudffs now has this race-free implementation, see commit https://github.com/pali/udftools/commit/6fb2b8f7a8d522040d97be9a835b2d71671e5028

Ad color support, e.g. `ls --color=auto` uses check based on isatty(). But I'm not sure what is expected or correct default behavior for udffsck.

As you are using mmap(), you should register handler for SIGBUS to catch unexpected errors like for SIGGEGV. Also you should use sigaction() instead of signal().

Ad blocksize: On UDF disk it is stored in Logical Volume Descriptor in field logicalBlockSize. But LVD is not possible to parse without knowing blocksize, so after blocksize is detected,...

For 1.0 todo there should be also: * documentation which disk is (or is not) udffsck able to repair... (e.g. from code I can see it does not support disks...

Basically now I have prepared everything, including updates to manual pages. If I do not find any other bugs then udftools 2.0 is ready. Mhm... I think it would be...