.disabled is improperly set when reusing a settings object

[dovrosenberg]

trafficstars

When I reuse a settings object by passing it into initDialog() and then after that dialog closes using it again to initialize a new one, the buttons all become disabled.

Perhaps this is a bad practice, as the settings object is modified by initDialog(), but it seems like it should be doable in order to limit the need to recreate the same object over and over.

In any case, the problem seems to be this line in initDialog() doesn't work if .disabled is already a ReactiveVar:

newButton.disabled = new ReactiveVar((info.buttons[button].disabled === undefined || info.buttons[button].disabled === false) ? false : true);

Perhaps it should be something like: newButton.disabled = new ReactiveVar((info.buttons[button].disabled === undefined || info.buttons[button].disabled === false || (info.buttons[button].disabled instanceof ReactiveVar && info.buttons[button].disabled.curValue===false)) ? false : true);

[jchristman]

+1 please merge the solution. I am having this same problem.

[pahans]

i am busy with a personal matter for few days. can some one test this PR and confirm it?, so i can merge it. thanks in advance.

[jchristman]

Error with code. See my comments on the PR.

[jchristman]

@pahans, do you know when you might get a chance to publish to atmosphere? Also, I think you can close this issue now.

[jchristman]

@dovrosenberg, seeing as the atmosphere package was never updated with your change and another PR I made was never merged, I have created a new atmosphere package with yours and my change in it. See https://atmospherejs.com/jchristman/reactive-modal.

[dovrosenberg]

Thanks, @jchristman